HDDS-13474. Support abort incomplete multipart upload action#10052
Open
YutaLin wants to merge 4 commits intoapache:HDDS-8342from
Open
HDDS-13474. Support abort incomplete multipart upload action#10052YutaLin wants to merge 4 commits intoapache:HDDS-8342from
YutaLin wants to merge 4 commits intoapache:HDDS-8342from
Conversation
spacemonkd
changed the title
ivandika3
reviewed
Apr 9, 2026
| return false; | ||
| } | ||
|
|
||
| // TODO: Add tag filtering support when multipart uploads support tags |
Contributor
There was a problem hiding this comment.
Multipart uploads should already support tagging so we can support tag based filtering support.
| } | ||
|
|
||
| @Test | ||
| public void testGetLifecycleWithAbortIncompleteMultipartUpload() throws Exception { |
Contributor
There was a problem hiding this comment.
Let's add or modify the test in AbstractS3SDKV1Tests and AbstractS3SDKV2Tests to test the E2E flow.
| * @param bucketInfo the bucket information | ||
| * @param ruleList list of lifecycle rules to evaluate | ||
| */ | ||
| private void processMultipartUploads(OmBucketInfo bucketInfo, List<OmLCRule> ruleList) { |
Contributor
There was a problem hiding this comment.
Please add a test in TestKeyLifecycleService to test this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support AbortIncompleteMultipartUpload action
Please describe your PR in detail:
configure a lifecycle rule by using the AbortIncompleteMultipartUpload action to minimize storage costs.
What is the link to the Apache JIRA
https://docs.aws.amazon.com/AmazonS3/latest/userguide/mpu-abort-incomplete-mpu-lifecycle-config.html
How was this patch tested?
Add unit tests and xml tests
CI Action (https://github.com/YutaLin/ozone/actions/runs/24017470716)